Plugin has a conflict with the built-in organize imports

[paustint]

As soon as VScode was updated to 1.31.0, it appears that this prettier extensions conflicts with the the built-in organize imports setting, when organize imports on save is enabled.

prettier: "prettier": "^1.16.4", (was initially on 1.13.7, tried to update)
vscode: Version 1.31.0 (1.31.0)
extension: 1.8.0

I first opened a ticket with vscode core, but was referred to the extension as the source of the problem:
microsoft/vscode#68193

Steps to reproduce

1. Add setting for editor.codeActionsOnSave.source.organizeImports = true (see below for example json)
2. Ensure prettier is configured to format on save
3. create a ts file (may also work with js) that has an import that exceeds the configured line length, which should be turned into a multi-line import
4. Save file

Expected behavior:

1. imports should be organized
2. imports should be formatted to multi-line import
3. file should be saved

Actual behavior:

1. imports are organized
2. imports remain on a single line
3. file remains "dirty" - with the little white dot in the tab-bar

Note:
I can format the document manually using the command menu and the import is correctly formatted, but then on save it is unformatted and the file shows as modified by the file system.

"editor.codeActionsOnSave": {
    "source.organizeImports": true
},

Initial file

Format file manually, just to show that it works

After Save (cmd+s)

[beeme1mr]

I'm running into the same issue. I've disabled organize imports for now.

[nikivdev]

Can this be solved in some way? I would like to help if I can to implement this.

[hevans90]

This only seems to have happened with VSCode's refactor/extension of how code-formatters are chosen & configured. It is a shame because prior to this VSCode version you could have a nice formatOnSave + source.organizeImports combo which would work seamlessly.

I've tried to mess with the timeouts of these actions, but no workaround seems to be consistent here. Turning this off for now :(

[hevans90]

After playing with some of the VSCode settings a bit more, you can make the editor behave in a REALLY strange way:

And look at what happens if you repeatedly save the file:

Yep, either Prettier or VSCode's organizeImports breaks code - looks like a race condition. I'd stay away from organizeImports for now.

[marty-wang]

Any member can chime in?

[felixfbecker]

I get severely corrupted files from this all the time. Looks like some kind of serious race condition

[AlberErre]

same issue here, any workaround?

[Undistraction]

@ntotten I think this is a bug, not an enhancement. It means Prettier VSCode is totally incompatible with one of VSCode's more useful features.

[jaywhy13]

I'm having this same issue too. I think I might have to disable this too.

[satelllte]

I'm having a similar issue w/ end of file & braces:
Is it this bug too?

[janosh]

It seems weird that this is getting so little attention, considering it's the 3rd most upvoted issue of prettier-vscode. @nikitavoloboev even offered to help. Couldn't a member pick him up on that?