Skip to content

Conversation

@Boshen
Copy link
Contributor

@Boshen Boshen commented Sep 19, 2024

This PR upgrades oxlint to the latest version and turns off react/no-danger-with-children for the test case

it('should unmount dangerouslySetInnerHTML', () => {
let set;
const TextDiv = () => (
<div dangerouslySetInnerHTML={{ __html: '' }}>some text</div>
);

as preact doesn't seem to throw a runtime warning for using children and the dangerouslySetInnerHTML prop at the same time https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-danger-with-children.md.

@coveralls
Copy link

Coverage Status

coverage: 99.488%. remained the same
when pulling 8086de8 on Boshen:main
into 1807173 on preactjs:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants