Skip to content

Golf down children #4485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

Golf down children #4485

merged 1 commit into from
Aug 30, 2024

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Aug 30, 2024

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 30, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-6.02ms - +4.26ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.08ms - +0.07ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +1% (-0.69ms - +0.97ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -4% - +3% (-0.61ms - +0.52ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +3% (-1.43ms - +2.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -6% - +3% (-0.12ms - +0.05ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +0% (-0.43ms - +0.17ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +2% (-1.69ms - +0.55ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +2% (-0.53ms - +0.25ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - -0% (-0.01ms - -0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - +1% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local920.85ms - 925.59ms-unsure 🔍
-1% - +0%
-6.02ms - +4.26ms
preact-main919.53ms - 928.65msunsure 🔍
-0% - +1%
-4.26ms - +6.02ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local25.24ms - 25.25ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main25.24ms - 25.25msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.58ms - 16.70ms-unsure 🔍
-0% - +0%
-0.08ms - +0.07ms
preact-main16.59ms - 16.69msunsure 🔍
-0% - +0%
-0.07ms - +0.08ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.63ms - 1.63ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.63ms - 1.63msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local69.10ms - 70.60ms-unsure 🔍
-1% - +1%
-0.69ms - +0.97ms
preact-main69.36ms - 70.05msunsure 🔍
-1% - +1%
-0.97ms - +0.69ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local14.77ms - 15.36ms-unsure 🔍
-4% - +2%
-0.53ms - +0.25ms
preact-main14.95ms - 15.47msunsure 🔍
-2% - +4%
-0.25ms - +0.53ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.46ms - 17.03ms-unsure 🔍
-4% - +3%
-0.61ms - +0.52ms
preact-main16.30ms - 17.28msunsure 🔍
-3% - +4%
-0.52ms - +0.61ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.54ms - 4.54ms-unsure 🔍
-0% - -0%
-0.01ms - -0.00ms
preact-main4.54ms - 4.55msunsure 🔍
+0% - +0%
+0.00ms - +0.01ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local77.28ms - 79.69ms-unsure 🔍
-2% - +3%
-1.43ms - +2.00ms
preact-main76.98ms - 79.43msunsure 🔍
-3% - +2%
-2.00ms - +1.43ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.54ms - 3.55ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main3.55ms - 3.56msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local30.24ms - 30.83ms-unsure 🔍
-2% - +1%
-0.68ms - +0.39ms
preact-main30.23ms - 31.13msunsure 🔍
-1% - +2%
-0.39ms - +0.68ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local34.92ms - 36.29ms-unsure 🔍
-4% - +1%
-1.29ms - +0.54ms
preact-main35.38ms - 36.58msunsure 🔍
-2% - +4%
-0.54ms - +1.29ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local26.12ms - 26.67ms-unsure 🔍
-2% - +1%
-0.62ms - +0.38ms
preact-main26.09ms - 26.93msunsure 🔍
-1% - +2%
-0.38ms - +0.62ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local29.28ms - 31.06ms-unsure 🔍
-0% - +8%
-0.08ms - +2.32ms
preact-main28.24ms - 29.86msunsure 🔍
-8% - +0%
-2.32ms - +0.08ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local20.73ms - 21.19ms-unsure 🔍
-2% - +1%
-0.52ms - +0.16ms
preact-main20.89ms - 21.39msunsure 🔍
-1% - +2%
-0.16ms - +0.52ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local23.96ms - 25.04ms-unsure 🔍
-3% - +3%
-0.77ms - +0.74ms
preact-main23.98ms - 25.04msunsure 🔍
-3% - +3%
-0.74ms - +0.77ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.97ms - 2.09ms-unsure 🔍
-6% - +3%
-0.12ms - +0.05ms
preact-main2.00ms - 2.12msunsure 🔍
-3% - +6%
-0.05ms - +0.12ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.07ms - 1.08ms-unsure 🔍
-0% - +1%
-0.00ms - +0.01ms
preact-main1.07ms - 1.08msunsure 🔍
-1% - +0%
-0.01ms - +0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local34.23ms - 34.51ms-unsure 🔍
-1% - +0%
-0.43ms - +0.17ms
preact-main34.24ms - 34.77msunsure 🔍
-0% - +1%
-0.17ms - +0.43ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.19ms - 1.19ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main1.19ms - 1.19msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.85ms - 35.09ms-unsure 🔍
-5% - +2%
-1.69ms - +0.55ms
preact-main34.11ms - 35.97msunsure 🔍
-2% - +5%
-0.55ms - +1.69ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.48ms - 3.49ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main3.48ms - 3.49msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-

tachometer-reporter-action v2 for Benchmarks

JoviDeCroock
JoviDeCroock commented Aug 30, 2024
View reviewed changes
src/diff/children.js
Comment on lines -67 to -68
typeof childVNode == 'boolean' ||
typeof childVNode == 'function'
Copy link
Member Author

@JoviDeCroock JoviDeCroock Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already handle these during the new array construction

JoviDeCroock
JoviDeCroock commented Aug 30, 2024
View reviewed changes
src/diff/children.js
typeof childVNode == 'function'
) {
childVNode = newParentVNode._children[i] = null;
continue;
Copy link
Member Author

@JoviDeCroock JoviDeCroock Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was repeated on line 230-234

JoviDeCroock
JoviDeCroock commented Aug 30, 2024
View reviewed changes
src/diff/children.js
childVNode._flags |= INSERT_VNODE;
}
// In the former two branches we know that it matches after skewing
childVNode._flags |= INSERT_VNODE;
Copy link
Member Author

@JoviDeCroock JoviDeCroock Aug 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is always going to be truthy now, the +1 branches made it falsy so we can just assign it in this one

@github-actions
Copy link

github-actions bot commented Aug 30, 2024

Size Change: -57 B (-0.09%)

Total Size: 61.7 kB

Filename Size Change
dist/preact.js 4.66 kB -9 B (-0.19%)
dist/preact.min.js 4.69 kB -8 B (-0.17%)
dist/preact.min.module.js 4.69 kB -9 B (-0.19%)
dist/preact.min.umd.js 4.71 kB -8 B (-0.17%)
dist/preact.module.js 4.68 kB -13 B (-0.28%)
dist/preact.umd.js 4.73 kB -10 B (-0.21%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.11 kB
compat/dist/compat.module.js 4.04 kB
compat/dist/compat.umd.js 4.18 kB
debug/dist/debug.js 3.7 kB
debug/dist/debug.module.js 3.71 kB
debug/dist/debug.umd.js 3.78 kB
devtools/dist/devtools.js 259 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 345 B
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 981 B
jsx-runtime/dist/jsxRuntime.module.js 956 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

coveralls commented Aug 30, 2024 •
edited
Loading

Coverage Status

coverage: 99.486% (+0.002%) from 99.484%
when pulling 239b576 on golfing-children
into 1a6bd4d on main.

@JoviDeCroock JoviDeCroock merged commit 4e7e29b into main Aug 30, 2024
@JoviDeCroock JoviDeCroock deleted the golfing-children branch August 30, 2024 07:50
@JoviDeCroock JoviDeCroock mentioned this pull request Sep 14, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Oct 5, 2024
Open
@lorenzoAtBEIS lorenzoAtBEIS mentioned this pull request Oct 7, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Oct 18, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 25, 2024
Open
@Xcaciv Xcaciv mentioned this pull request Oct 27, 2024
Open
@dwhiteGUK dwhiteGUK mentioned this pull request Oct 28, 2024
Closed
@X-oss-byte X-oss-byte mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoviDeCroock @coveralls @marvinhagemeister