Skip to content

Add TypeScript support for Container.contains #4471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 6, 2024
Merged

Add TypeScript support for Container.contains #4471

merged 4 commits into from
Aug 6, 2024

Conversation

@sjoerdmulder
Copy link
Contributor

@sjoerdmulder sjoerdmulder commented Aug 6, 2024

Recently the code started using the contains method on the Node interface but this is not exposed in the types causing a runtime crash when implementing your own ContainerNode

@JoviDeCroock JoviDeCroock changed the title Adding contains method to ContainerNode Add TypeScript support for Container.contains Aug 6, 2024
@coveralls
Copy link

coveralls commented Aug 6, 2024 •
edited
Loading

Coverage Status

coverage: 99.486%. remained the same
when pulling 8b046de on sjoerdmulder:patch-1
into ab743a9 on preactjs:main.

JoviDeCroock
JoviDeCroock approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JoviDeCroock JoviDeCroock merged commit 91679e5 into preactjs:main Aug 6, 2024
@sjoerdmulder sjoerdmulder deleted the patch-1 branch August 6, 2024 13:54
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 12, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Sep 3, 2024
Open
@lorenzoAtBEIS lorenzoAtBEIS mentioned this pull request Sep 7, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Sep 8, 2024
Open
@arkid15r arkid15r mentioned this pull request Sep 11, 2024
Closed
@ntavassoli-dot ntavassoli-dot mentioned this pull request Sep 13, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 5, 2024
Open
@lorenzoAtBEIS lorenzoAtBEIS mentioned this pull request Oct 7, 2024
Merged
@X-oss-byte X-oss-byte mentioned this pull request Oct 18, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 25, 2024
Open
@Xcaciv Xcaciv mentioned this pull request Oct 27, 2024
Open
@dwhiteGUK dwhiteGUK mentioned this pull request Oct 28, 2024
Closed
@X-oss-byte X-oss-byte mentioned this pull request Nov 8, 2024
Open
@rschristian rschristian mentioned this pull request Jan 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sjoerdmulder @coveralls @JoviDeCroock