Separate template submission from saving #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 24, 2025 08:19
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||
added 2 commits
April 24, 2025 10:36
rudigiesler
reviewed
Apr 24, 2025
There was a problem hiding this comment.
Looks good!
I don't see where we're doing deduplication now though. If we submit the same template under a different name, Meta rejects it. I think since we're no longer submitting on every revision, we should look up the latest revision that has been submitted, and compare it to the current one. If it's changed, then we resubmit. If it hasn't, then we just copy the template name over to the current revision.
added 5 commits
April 24, 2025 13:31
…e_revision methods
…t make additional revisions
…ubmitted, and to update the live object if the live object is submitted
rudigiesler
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
At the moment, whenever you save a new revision of a template, it gets submitted.
We want to separate the submission action from the saving action, so that we get to decide when it is submitted to Meta.
Solution
This separates the submission action from the saving action and adds a submission button and a bulk submit action
Checklist