Preserve type when writing to ps_crud
#117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trigger responsible for writing into
ps_crud
used to apply theconcat
function on values in text columns to strip out the JSON subtype (avoiding e.g.SET foo = json_object()
to be encoded as a nested JSON object instead of the string"{}"
).Unfortunately, that logic was flawed in two ways:
concat
turns a null input value into an empty string.As a solution, this introduces the
powersync_strip_subtype
function that preserves the type of the input value but will always replace the subtype of the value with0
.