-
Notifications
You must be signed in to change notification settings - Fork 59
fix: Potential Multitab Transaction Issues With IndexedDB #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 8fc41a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the overall approach - just have a minor comment on the holds that may affect performance.
Problem
A db transaction death-loop could occur when using IndexedDB across multiple tabs, manifesting as the error:
This happens when a tab holding an active SQLite transaction is closed before committing or rolling back that transaction. Since IndexedDB shares a single SQLite connection (via a shared web worker) across all tabs, the uncommitted transaction persists and blocks subsequent transaction attempts.
Root Cause
BEGINstatements fail because a transaction is already in progressSolution
This PR implements a connection "hold" mechanism:
ROLLBACKto clean up the orphaned transactionThis ensures transactions are always resolved, even when tabs close unexpectedly.