Skip to content

Conversation

Chriztiaan
Copy link
Contributor

@Chriztiaan Chriztiaan commented Apr 23, 2025

This should be the last of 3 logging cleanup PRs. It uses the recently introduced Logging helpers instead of using js-logger. This allows us to drop the js-logger dependency from and potentially vite config from all our demos.

I have tested this change on most of the demos.

Copy link

changeset-bot bot commented Apr 23, 2025

⚠️ No Changeset found

Latest commit: 12c52c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from feat/logging-cleanup to main April 24, 2025 08:54
@Chriztiaan Chriztiaan marked this pull request as ready for review April 24, 2025 09:16
@Chriztiaan Chriztiaan merged commit 5496019 into main Apr 24, 2025
6 checks passed
@Chriztiaan Chriztiaan deleted the feature/logging-cleanup-demos branch April 24, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants