Fix tests so that they also work locally #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two tests hardcode the error message, so they are language- dependent.
FranklinYu
commented
Jan 28, 2022
Otherwise it returns with the last status, and shows misleading error
messages like
shunit2:WARN oneTimeTearDown() returned non-zero return code.
Otherwise, the developer’s shell configuration might break tests when running locally.
Contributor
Author
|
Quote from Bash manual supporting 49c9b49:
Example: func() { return; }
false
func || echo 'Error!' |
postmodern
reviewed
Jan 28, 2022
Owner
postmodern
left a comment
postmodern
left a comment
There was a problem hiding this comment.
Minor question regarding bash vs zsh with LANG.
Owner
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test works in GitHub Action environment, but it doesn’t work on all environments. This PR is trying to make the test more robust, and allow it to run on more environments (such as the one I develop on).