Skip to content

Conversation

parthverma1
Copy link
Contributor

Added support for an SSL key log file to facilitate debugging encrypted network traffic. Updated dependency postman-request to include the relevant SSL key logging feature.

Added support for an SSL key log file to facilitate debugging encrypted network traffic. Updated dependency `postman-request` to include the relevant SSL key logging feature.
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds SSL key logging functionality to enable debugging of encrypted network traffic by allowing users to specify a file path for logging SSL session keys.

  • Updated postman-request dependency to use a feature branch with SSL key logging support
  • Added debug option configuration that gets passed through the runner chain
  • Implemented SSL key log file path extraction and assignment to request options

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Updated postman-request dependency to feature branch
lib/runner/index.js Added debug options to runner configuration
lib/requester/requester-pool.js Extracted SSL key log file path from debug options
lib/requester/core.js Assigned SSL key log file to request options
README.md Added documentation for debug.sslKeyLogFile option

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

options.ciphers = protocolProfileBehavior.tlsCipherSelection.join(':');
}

options.keyLog = defaultOpts.sslKeyLogFile;
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SSL key log file path is assigned directly without validation. Consider adding a check to ensure the path is a valid string before assignment to prevent potential issues with the underlying request library.

Suggested change
options.keyLog = defaultOpts.sslKeyLogFile;
if (typeof defaultOpts.sslKeyLogFile === 'string' && defaultOpts.sslKeyLogFile.length > 0) {
options.keyLog = defaultOpts.sslKeyLogFile;
}

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant