Skip to content

Conversation

kwongtn
Copy link
Contributor

@kwongtn kwongtn commented Dec 17, 2024

The existing declaration does not expose the deployment to collect metrics from the pods, hence no metrics are being collected.

This PR exposes the metrics port, and also includes a "for-convenience" PodMonitor.
As some of us may already have metrics setup, I bumped the semver by 1 minor version to prevent anyone accidentally updating & wiping their configs.

Closes #871

Depends on:

@kwongtn kwongtn mentioned this pull request Dec 17, 2024
@tomasz-torcz-airspace-intelligence

Could you also add pod annotation for classic Prometheus deployments?

metadata:
  annotations:
    prometheus.io/port: "9930"
    prometheus.io/scrape: "true"

@shigedangao
Copy link

shigedangao commented Mar 21, 2025

any update @kwongtn ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart: Prometheus exporter not in the service
3 participants