-
Notifications
You must be signed in to change notification settings - Fork 129
Assistant: Improves AWS SSO refresh flow #10617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
E2E Tests 🚀 |
timtmok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
57e69af to
3dfe117
Compare
|
When I start Positron with expired Bedrock credentials, I don't get any kind of error notification anymore. |
timtmok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Merging w/ known failures due to e2e disruption. |
Assistant now intercepts errors related to expired AWS Bedrock credentials, and prompts the user to refresh them. It provides an affordance on the error notification to automatically run

aws sso refresh, which opens the browser and starts the flow. It also returns Positron to the foreground once the refresh is complete.Addresses #9652
Release Notes
New Features
awsCLI tool.Bug Fixes
QA Notes
To "expire" your token:
~/.aws/sso/cache/[key].json. I identified it as the most recently updated file in that directory.expiresAtandregistrationExpiresAtto dates prior to present, and changeaccessTokenandrefreshTokenrandomly (I removed the first character).Cases to test
Adding Bedrock model
Expire your token, then signin to Bedrock in the Configure Model Providers dialog. This should trigger the refresh flow automatically.
Starting Positron with a Bedrock provider added
Expire your token, then refresh Positron. You should receive a notification to refresh credential. Clicking the button will launch the refresh flow in browser.
Token expires while Positron is open
Expire your token, then try to send a message. You will receive an error in chat, and the notification to prompt refresh. Note: Token credentials are cached in memory, so simply changing on disk is not sufficient. We may need to expire the token within AWS itself to test this properly. In dev, I created a command (removed from PR) to refresh the AWS token from disk.
e2e: @:assistant