Handle Updated Claims #389

jwicks31 · 2018-11-06T20:52:18Z

Description of Changes

Resolves #365 and Resolves #393 (If we are able to use it)

Updated work attributes to claim
Added Interfaces from updated poet-js
- I copied them over for now because there is a slight change I made to Claim by defining an interface rather than using the object type. This was so that I could read the individual claim properties.
- Another problem with importing the interfaces from poet-js is that it breaks the build because we do not have the correct loaded for something with jsonld

I wasn't sure how 'Dynamic' the claims needed to be.

Above the Work/Claim it will show an author, datePublished, dateModified, name, tags if they are available. If there is no author, it labels it "Unknown Author". If there is no name, it labels it "Untitled Work". It will not show anything for datePublished, dateModified, or tags if they aren't supplied.

In the Content Section of the Work/Claim it will show any keys/values that are supplied and not empty. It filters out for "text" and "content" and displays whichever of those is supplied below the other key/value pairs.

In the Technical Tab it lists all key/values form the timestamp attribute.

An example work id to test that the claims are loading is : a9cef68009c16fbaafabc2d423c269311a9392f2ce5a51f4944711bdfa73f1b7

The Netlify Deploy preview will open to regtest, but the work ID above is in testnet. Change the regtest in the link to say testnet eg:
https://deploy-preview-389--explorer-web-qa-testnet.netlify.com/works/a9cef68009c16fbaafabc2d423c269311a9392f2ce5a51f4944711bdfa73f1b7

… claims

lautarodragan · 2018-11-08T20:08:09Z

@jwicks31 @krobi64 @geoffturk what's the scope of this task? Should explorer-web be smart enough to parse the @context and dynamically refer to attributes based on it?

krobi64 · 2018-11-08T20:15:12Z

I am not sure that is required for mainnet. However, I do believe that we should look that way long term. jsonld can render the json and context with the appropriate schema references as the attribute name. For example:

{
   "schema:Book": {
     "schema:author": {
         "schema:name": {
             "value": "Sir Author Conan Doyle"
         }
     },
    "schema:title": "The Hound of the Baskervilles"
   }
}

This allows us to create a more flexible interface.

jwicks31 · 2018-11-08T20:26:34Z

I wasn't really sure of the scope either. I do think the scope for this PR should just be getting it functioning the way it was before, but with the new claim types. Then if we want to handle that change doing it separately.

lautarodragan · 2018-11-08T21:12:16Z

Thanks @krobi64

@jwicks31 agreed.

jwicks31 · 2018-11-13T18:14:04Z

webpack.config.js

@@ -125,13 +125,18 @@ module.exports = {
  resolve: {
    extensions: ['.webpack.js', '.web.js', '.ts', '.tsx', '.js', '.json', '.css', '.scss'],
    alias: {
-      Configuration: path.resolve(configurationPath)
+      Configuration: path.resolve(configurationPath),
+      jsonld$: path.resolve(__dirname, './node_modules/jsonld/dist/jsonld.min.js')


@lautarodragan @krobi64 When using @po.et/poet-js package I'm running into several problems. First the json-ld package was causing the error:

ERROR in ./node_modules/jsonld/lib/jsonld.js Module parse failed: Unexpected token (1040:2) You may need an appropriate loader to handle this file type. | function _setDefaults(options, { | documentLoader = jsonld.documentLoader, | ...defaults | }) { | if(typeof options === 'function') { @ ./src/utils/JSONLD.ts 3:15-32 @ ./src/index.ts Warning: Use --force to continue. Aborted due to warnings.

I was able to fix this in my local build with this line, which I got from the issues page: digitalbazaar/jsonld.js#252 (comment)

jwicks31 · 2018-11-13T18:16:17Z

webpack.config.js

    },
    modules:  [
      path.join(__dirname, "src"),
      "node_modules"
    ],
  },
+
+  node: {
+    net: 'empty',


@lautarodragan @krobi64 The joi dependency in poet-js was causing this error:
Module not found: Error: Cannot resolve module 'net' on node_modules/joi/lib @ ./~/joi/lib/string.js 3:10-24
I was able to fix this locally with this line, which I got from the joi issues: hapijs/joi#665 (comment)

uhmm because joi is not prepared to use in the front end. For this reason, I saw in several projects are using https://github.com/jquense/yup instead of joi

Maybe if we want to use poet-js in the backend and frontend, we have to use a library that works fine on the two sides

jwicks31 · 2018-11-13T18:22:05Z

@krobi64 @lautarodragan After making those changes to get everything building locally I was still getting a long list of errors in the Netlify Build that starts with:

> node-gyp rebuild
12:06:09 PM: make: Entering directory `/opt/build/repo/node_modules/rdf-canonize/build'
12:06:09 PM:   CXX(target) Release/obj.target/urdna2015/lib/native/IdentifierIssuer.o
12:06:10 PM:   CXX(target) Release/obj.target/urdna2015/lib/native/MessageDigest.o
12:06:10 PM:   CXX(target) Release/obj.target/urdna2015/lib/native/NQuads.o
12:06:10 PM: ../lib/native/NQuads.cc: In static member function ‘static std::string RdfCanonize::NQuads::serializeQuad(const RdfCanonize::Quad&)’:
12:06:10 PM: ../lib/native/NQuads.cc:72:62: error: no matching function for call to ‘regex_replace(std::string&, std::regex&, const char [3])’
12:06:11 PM:      escaped = regex_replace(escaped, REGEX_BACK_SLASH, "\\\\");
12:06:11 PM:                                                               ^
12:06:11 PM: ../lib/native/NQuads.cc:72:62: note: candidates are:
12:06:11 PM: In file included from /usr/include/c++/4.8/regex:62:0,
12:06:11 PM:                  from ../lib/native/NQuads.cc:13:
12:06:11 PM: /usr/include/c++/4.8/bits/regex.h:2162:5: note: template<class _Out_iter, class _Bi_iter, class _Rx_traits, class _Ch_type> _Out_iter std::regex_replace(_Out_iter, _Bi_iter, _Bi_iter, const std::basic_regex<_Ch_type, _Rx_traits>&, const std::basic_string<_Ch_type>&, std::regex_constants::match_flag_type)
12:06:11 PM:      regex_replace(_Out_iter __out, _Bi_iter __first, _Bi_iter __last,
12:06:11 PM:      ^
12:06:11 PM: /usr/include/c++/4.8/bits/regex.h:2162:5: note:   template argument deduction/substitution failed:
12:06:11 PM: ../lib/native/NQuads.cc:72:62: note:   deduced conflicting types for parameter ‘_Bi_iter’ (‘std::basic_regex<char>’ and ‘const char*’)

Uninstalling the package and just copying the interfaces over solved the issue, but other than that I haven't been able to find a solution. Another issue is that after updating it to the newest version security/snyk started to fail with 3 errors, but I was unable to read what they were. @warrenv

krobi64 · 2018-11-13T18:42:43Z

@jwicks31 For the build error, use this in the Dockerfile:

RUN apt-get update && apt-get install -y rsync \
                       gcc-5 \
                       g++-5 \
                       && rm -rf /var/lib/apt/lists/* \
                       && rm /etc/apt/sources.list.d/unstable.list

wzalazar · 2018-11-13T18:45:08Z

@jwicks31 @krobi64 we had this issue before and we can't install dependencies on Netlify

jwicks31 · 2018-11-13T18:47:37Z

@krobi64 @wzalazar Yeah I remember having this issue with Frost-web as well. I think we were trying to modify the Netlify.toml file though, so I went ahead with updating Docker to try. Still failing with the same errors though.

krobi64 · 2018-11-13T18:50:24Z

@jwicks31 @wzalazar that seems to be a serious limitation on Netlifty. Can we build and push a docker image that Netlifty then downloads?

jwicks31 · 2018-11-14T00:35:36Z

@krobi64 I'm not really sure, but I'm not finding anything on how to do it.

… claims

This reverts commit 53bdca4.

krobi64 · 2018-11-14T18:14:09Z

Ok, for now, let's remove po.et and bring the interface. It may be that the frost api will have to eventually return the object already deconstructed... but that's out of scope

jwicks31 · 2018-11-14T19:25:07Z

@wzalazar @lautarodragan @krobi64 This one is ready for review now. Thank you!

lautarodragan

LGTM

jwicks31 added 12 commits November 6, 2018 11:41

update claims

6aa825a

replace attributes with claim

4ae71bf

prepare for poet-js v5.1.4

a0e4402

handle text or content

e3af708

undo content name change

1235bc1

filter empty values

61c092c

filter empty values

700db31

Merge branch 'claims' of https://github.com/poetapp/explorer-web into…

8bb41e1

… claims

import claim

c932692

replace anys

df098c1

works content

d7c27a9

text changed back to content

e81723f

jwicks31 requested review from lautarodragan, warrenv and wzalazar November 6, 2018 20:52

jwicks31 and others added 3 commits November 6, 2018 14:52

Merge branch 'master' into claims

11f2356

lint:fix

a204b8b

Merge branch 'claims' of https://github.com/poetapp/explorer-web into…

8e045c9

… claims

jwicks31 self-assigned this Nov 6, 2018

jwicks31 added the don't merge label Nov 6, 2018

jwicks31 added 2 commits November 7, 2018 09:50

Merge branch 'master' into claims

4087a23

Merge branch 'master' into claims

e2c3149

Merge branch 'master' into claims

b49f875

jwicks31 removed the don't merge label Nov 8, 2018

jwicks31 added 2 commits November 9, 2018 10:31

Merge branch 'master' into claims

8252b00

Merge branch 'master' into claims

393d7cd

jwicks31 added 3 commits November 13, 2018 12:05

stop using poet-js

3a390bb

uninstalled @po.et/poet-js

131c9c0

undo travis changes

5200c16

jwicks31 commented Nov 13, 2018

View reviewed changes

jwicks31 added 2 commits November 13, 2018 12:17

lint:fix

171ca06

lint:fix

a39eda6

updated Dockerfile + added @po.et/poet-js back

3bce7d4

Merge branch 'master' into claims

39ef5a8

jwicks31 and others added 7 commits November 14, 2018 10:57

Merge branch 'master' into claims

6f9b0b6

updated travis config

367fb1d

Merge branch 'claims' of https://github.com/poetapp/explorer-web into…

a63a391

… claims

updated dockerfile

0b5ea50

lint:fix

4435a8c

netlify toml update test

53bdca4

Revert "netlify toml update test"

ef9f66d

This reverts commit 53bdca4.

jwicks31 added 2 commits November 14, 2018 12:26

removed @po.et/poet-js

f1a586f

fix merge mistakes

df002af

lautarodragan approved these changes Nov 14, 2018

View reviewed changes

jwicks31 merged commit 910d8ca into master Nov 14, 2018

jwicks31 deleted the claims branch November 14, 2018 23:34

lautarodragan mentioned this pull request Nov 16, 2018

Install @po.et/poet-js: Netlify Breaking #418

Closed

Handle Updated Claims #389

Handle Updated Claims #389

Uh oh!

Conversation

jwicks31 commented Nov 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Changes

Uh oh!

lautarodragan commented Nov 8, 2018

Uh oh!

krobi64 commented Nov 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jwicks31 commented Nov 8, 2018

Uh oh!

lautarodragan commented Nov 8, 2018

Uh oh!

jwicks31 Nov 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jwicks31 Nov 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wzalazar Nov 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jwicks31 commented Nov 13, 2018

Uh oh!

krobi64 commented Nov 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wzalazar commented Nov 13, 2018

Uh oh!

jwicks31 commented Nov 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

krobi64 commented Nov 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jwicks31 commented Nov 14, 2018

Uh oh!

krobi64 commented Nov 14, 2018

Uh oh!

jwicks31 commented Nov 14, 2018

Uh oh!

lautarodragan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jwicks31 commented Nov 6, 2018 •

edited

Loading

krobi64 commented Nov 8, 2018 •

edited

Loading

jwicks31 Nov 13, 2018 •

edited

Loading

jwicks31 Nov 13, 2018 •

edited

Loading

wzalazar Nov 13, 2018 •

edited

Loading

krobi64 commented Nov 13, 2018 •

edited

Loading

jwicks31 commented Nov 13, 2018 •

edited

Loading

krobi64 commented Nov 13, 2018 •

edited

Loading