Refactor GetCopilotAgent to streamline agent retrieval and improve query execution #4877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors GetCopilotAgent to improve agent retrieval by implementing proper pagination and more robust query execution. Key changes include:
- Updating the list query to use the DocumentLibrary enum rather than a magic number.
- Replacing ExecuteQuery with ExecuteQueryRetry for improved reliability.
- Refactoring the GetAgents method to internally manage pagination and directly process query batches.
Comments suppressed due to low confidence (1)
src/Commands/Copilot/GetCopilotAgent.cs:50
- [nitpick] The method name 'GetAgents' might be misleading as it not only retrieves but also writes out agent data with pagination. Consider renaming it to more clearly indicate its side effects, for example, 'WriteAgentsWithPagination'.
private void GetAgents(List list)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Fixes #4798
What is in this Pull Request ?
Adding proper pagination for the cmdlet