Skip to content

New command: spo list defaultvalue get. Closes #6535 #6967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Ateina wants to merge 1 commit into from
Closed

New command: spo list defaultvalue get. Closes #6535 #6967

Ateina wants to merge 1 commit into from

Conversation

@Ateina
Copy link
Contributor

@Ateina Ateina commented Oct 2, 2025

Closes #6535

@Adam-it
Copy link
Member

Adam-it commented Oct 2, 2025

Thank you for opening the PR 👏
We will review it ASAP

@Adam-it Adam-it self-assigned this Oct 23, 2025
@Adam-it Adam-it requested a review from Copilot October 24, 2025 13:44
Copilot AI reviewed Oct 24, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new command spo list defaultvalue get to retrieve a specific default column value from a SharePoint document library. The command supports retrieval by list ID, title, or URL, and can optionally filter by folder location.

Key Changes:

  • Added new command to retrieve default column values from a document library
  • Implemented XML parsing for SharePoint's client_LocationBasedDefaults.html file
  • Added comprehensive test coverage with multiple scenarios including error handling

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/m365/spo/commands/list/list-defaultvalue-get.ts Core command implementation with XML parsing and API integration
src/m365/spo/commands/list/list-defaultvalue-get.spec.ts Comprehensive test suite covering all command scenarios
src/m365/spo/commands.ts Command registration in the commands list
docs/src/config/sidebars.ts Documentation navigation entry
docs/docs/cmd/spo/list/list-defaultvalue-get.mdx User-facing command documentation
.devproxy/api-specs/sharepoint.yaml API endpoint specifications for dev proxy

Adam-it
Adam-it requested changes Oct 24, 2025
View reviewed changes
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅Tested locally works perfectly
@Ateina amaizing work 😍
I don't have much to add. I only added two comments which will improve the reusability of our codebase. Please consider them before we proceed.
Copilot also noticed some minor things we could fixup.
Other than that seems very solid 👍
You Rock 🤩

@Adam-it Adam-it marked this pull request as draft October 24, 2025 22:51
@Adam-it Adam-it added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 29, 2025
@Ateina
Copy link
Contributor Author

Ateina commented Nov 4, 2025

@Adam-it Thank you for the review 💚
I thought about moving these methods but wasn't sure if it should be done in this PR
Will fix all comments and update the PR asap 👍

@Adam-it
Copy link
Member

Adam-it commented Dec 10, 2025

@Ateina I saw you added a commit with a fixup I guess. If you think the PR is read for another go and to be merged use the ready for review button to let us know if we may proceed 👍

@Ateina Ateina marked this pull request as ready for review December 11, 2025 13:14
@Adam-it
Copy link
Member

Adam-it commented Dec 14, 2025

@Ateina I just noticed your reply to one of my comments when doing the review. So sorry I did not respond sooner.
I left some guidance on what would be the best way to proceed. Let me know if this is something you could tweak as well and besides that, we should be ready to merge 👍

@Adam-it Adam-it marked this pull request as draft December 14, 2025 22:15
@Ateina Ateina marked this pull request as ready for review December 18, 2025 21:18
@Ateina
Copy link
Contributor Author

Ateina commented Dec 18, 2025

@Adam-it Thank you 💚
I’ve moved the duplicated code to the utils.
If anything else is needed, no problem to update 🙂

@Ateina Ateina requested a review from Adam-it January 2, 2026 19:13
@Ateina Ateina marked this pull request as draft January 2, 2026 19:52
@Ateina Ateina force-pushed the 6535-m365-spo-list-defaultvalue-get branch from dc92b31 to 6fc9591 Compare January 2, 2026 20:21
@Ateina Ateina force-pushed the 6535-m365-spo-list-defaultvalue-get branch from 52d8540 to 0770e6b Compare January 2, 2026 21:06
@Ateina Ateina marked this pull request as ready for review January 2, 2026 21:08
@Ateina
Copy link
Contributor Author

Ateina commented Jan 2, 2026

Updated with Zod v4

Adam-it
Adam-it approved these changes Jan 3, 2026
View reviewed changes
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👏
You Rock 🤩

@Adam-it
Copy link
Member

Adam-it commented Jan 3, 2026

ready to merge 🚀

@Adam-it
Copy link
Member

Adam-it commented Jan 3, 2026

merged manually

@Adam-it Adam-it closed this Jan 3, 2026
@Ateina
Copy link
Contributor Author

Ateina commented Jan 3, 2026

@Adam-it Thank you for review and help with this PR ✨✨✨

@Adam-it
Copy link
Member

Adam-it commented Jan 3, 2026

@Adam-it Thank you for review and help with this PR ✨✨✨

No problem, and sorry for the huuuuuge holdup on this PR from my side. I wanted to merge it a bit sooner, but life stuff got in the way and occupied my time during the last month 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Adam-it Adam-it Adam-it approved these changes

Assignees

@Adam-it Adam-it

Labels

hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New command: spo list defaultvalue get

2 participants

@Ateina @Adam-it