fix: dispose and lazy setters #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abernier
commented
May 12, 2023
| @@ -1,3 +1,4 @@ | |||
| export * from './effects/Autofocus' | |||
Member
Author
There was a problem hiding this comment.
I moved Autofocus to the effects/ folder
abernier
commented
May 12, 2023
Comment on lines
+59
to
+60
| depthPickingPass.dispose() | ||
| copyPass.dispose() |
Member
Author
There was a problem hiding this comment.
not missing .dispose() this time
abernier
commented
May 12, 2023
Comment on lines
+46
to
+47
| const [depthPickingPass] = useState(() => new DepthPickingPass()) | ||
| const [copyPass] = useState(() => new CopyPass()) |
CodyJasonBennett
approved these changes
May 12, 2023
Member
|
can you create a CSB or StackBlitz to test if it's working? |
Member
Author
|
I'm actually taking the opportunity to setup Storybook for the repo (like we have in rt/drei), so we can test rt/pp components directly from source-code in this PR: #202 |
Member
Author
Yes, I've tested it on my csb https://codesandbox.io/s/dfw6w4, it is working as before :) |
|
🎉 This PR is included in version 2.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.dispose()ing objecteffects/folder