Ohlc trace type #264
Ohlc trace type #264
Conversation
See this issue for more explanations: plotly/plotly.js#2281
… if no trace.name was set by user
|
ok @nicolaskruchten would you like to give this a review? if you have a moment to take a look @bpostlethwaite I wouldn't refuse either :) |
src/DefaultEditor.js
Outdated
| /> | ||
| </Section> | ||
|
|
||
| <Section name={_('Increasing Trace Styles')}> |
There was a problem hiding this comment.
Should this be "Decreasing" instead of "Increasing" ?
| @@ -1,6 +1,6 @@ | |||
| import React, {Component} from 'react'; | |||
| import ReactDOM from 'react-dom'; | |||
| import plotly from 'plotly.js/dist/plotly-basic'; | |||
| import plotly from 'plotly.js/dist/plotly'; | |||
There was a problem hiding this comment.
Hmmm this might cause an issue with webpack when uglifying... The test I'm running now is almost at 10 minutes and it's still not done :(
There was a problem hiding this comment.
-basic took 153s to complete with webpack -p
There was a problem hiding this comment.
but this is what I need to get all my other chart types..
if I don't have this, I only get the basic 5 chart types, I think it's ok that we add a fuller version into the dev env
There was a problem hiding this comment.
for the dev env ok but this won't work for something like the simple app: we'll need to load plotly.js the proper way i.e. not from dist :)
There was a problem hiding this comment.
ah I see : ) ok, well, I'll merge this for now
|
I'll link this issue here for reference, about the difference of _fullInput vs _fullData: plotly/plotly.js#2281 But, I know that for composed traced types, like financial charts, the true attributes of the trace are in _fullInput. However, _fullInput doesn't seem to contain everything that _fullData contains. Well, we should be good for now I think :) |
ohlc attributes: https://github.com/plotly/plotly.js/blob/master/src/traces/ohlc/attributes.js