You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, for fin charts, the true type of a trace is found in gd._fullData[0]._fullInput.type
And I was thinking that perhaps to look for all of the 'true' values for a trace, instead of looking in _fullData as we always are, we could always by default look into the _fullInput object.
But it turns out the _fullInput object is not as complete as the _fullData one.
Was wondering if it'd be hard/possible to have everything in _fullInput so as to use that as the most complete reference to a trace's attributes? @alexcjohnson@etpinard ?
thanks!
The text was updated successfully, but these errors were encountered:
VeraZab
added a commit
to plotly/react-chart-editor
that referenced
this issue
Jan 23, 2018
fullInput is what we should use to build the toolpanel for finance traces.
True fullInput.line is incomplete (actually I think it should be undefined 🤔 ), but I think fullInput.increasing.line and fullInput.decreasing.line are the attributes of interest here.
Closing. I think the conclusion to make here is: ohlc and candlestick are a mess. We should try to rewrite them using a convention plot step (instead of our brutal transform trace hack). This should make everyone (toolpanel dev included) happy.
So, for fin charts, the true type of a trace is found in gd._fullData[0]._fullInput.type
And I was thinking that perhaps to look for all of the 'true' values for a trace, instead of looking in _fullData as we always are, we could always by default look into the _fullInput object.
But it turns out the _fullInput object is not as complete as the _fullData one.
Here's an example with ohlc charts. You can find line.color in _fullData, but not in _fullInput.
https://codepen.io/veraz/pen/KZYRVe?editors=1010
Was wondering if it'd be hard/possible to have everything in _fullInput so as to use that as the most complete reference to a trace's attributes? @alexcjohnson @etpinard ?
thanks!
The text was updated successfully, but these errors were encountered: