Skip to content

fix issues and awesome improvements in surfc functionality #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gilbertogalvis
Copy link
Contributor

This PR fix issues and do awesome improvements with surfc functionality. surfc previous version was very poor and failed for many cases. This new version is really awesome and work for any case. This PR was tested for all examples in https://github.com/plotly/ssim_baselines/tree/main/matlab/code-examples/surface-and-mesh-plots/surfc

It is very important to highlight that to use this new functionality, TreatAs optional parameter must set to surfc. Example of usage bellow

[X,Y] = meshgrid(1:0.5:10,1:20);
Z = sin(X) + cos(Y);
surfc(X,Y,Z, 'EdgeColor', 'yellow');

f = fig2plotly(gcf, 'offline', true,  'TreatAs', 'surfc');

Screenshots of results are shown bellow

Screen Shot 2021-09-16 at 10 07 35 PM

Screen Shot 2021-09-16 at 10 08 00 PM

Screen Shot 2021-09-16 at 10 08 24 PM

Screen Shot 2021-09-16 at 10 08 48 PM

Screen Shot 2021-09-16 at 10 09 24 PM

Screen Shot 2021-09-16 at 10 09 49 PM

Links to Chart-Studio bellow:

https://chart-studio.plotly.com/~galvisgilberto/4410/#/
https://chart-studio.plotly.com/~galvisgilberto/4412/#/
https://chart-studio.plotly.com/~galvisgilberto/4414/#/
https://chart-studio.plotly.com/~galvisgilberto/4416/#/
https://chart-studio.plotly.com/~galvisgilberto/4418/#/
https://chart-studio.plotly.com/~galvisgilberto/4420/#/

@gilbertogalvis gilbertogalvis merged commit 8af0338 into master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants