Skip to content

Conversation

@Kully
Copy link
Contributor

@Kully Kully commented Jan 6, 2017

No description provided.

@Kully Kully changed the title webgl in scaterplotmatrix webgl in scatterplotmatrix Jan 6, 2017
@Kully
Copy link
Contributor Author

Kully commented Jan 6, 2017

@theengineear ready for review

@Kully
Copy link
Contributor Author

Kully commented Jan 6, 2017

Will merge with master after #652 is merged, then we can work on this PR.

@etpinard
Copy link
Contributor

etpinard commented Jan 6, 2017

That's a horrible idea. gl2d subplots are sloooooooooow. Even though individual gl2d subplots can display far more points than their svg counterpart, graphs with 4+ gl2d subplots are incredibly slow to render at the moment.

@Kully
Copy link
Contributor Author

Kully commented Jan 6, 2017

That's a horrible idea. gl2d subplots are sloooooooooow. Even though individual gl2d subplots can display far more points than their svg counterpart, graphs with 4+ gl2d subplots are incredibly slow to render at the moment.

Okay, so I wasn't crazy when I was seeing avg run times that were greater in webgl vs non webgl subplots.

I was only doing this for a user who asked for this feature to speed up their scatterplotmatrices. I suppose I'll just let them know all this

@etpinard
Copy link
Contributor

etpinard commented Jan 6, 2017

@Kully Probably a good idea to point plotly.py gl2d users to plotly/plotly.js#130 for more info on the current limitations.

@theengineear
Copy link
Contributor

Disregard that deleted comment, I read @etpinard's comment too fast. Sweet, thanks chiming in on this one.

@Kully
Copy link
Contributor Author

Kully commented Jan 6, 2017

Cool, I have no problem adding this in now. It's just an minor inconvenience wrt conflicts, that's all.

If it's slower tho, i should abandon the PR no?

@Kully Kully closed this Jan 6, 2017
@nicolaskruchten nicolaskruchten deleted the webgl-spm branch June 19, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants