py2.6 support #635
py2.6 support #635
Conversation
|
@casperdcl , thanks for the PR, but we decided to drop python 2.6 support in #252. We will continue to support Python 2.7 for the foreseeable future though. //cc @chriddyp (in case you want to go back on the python 2.6 thing) |
|
I'm going to close this for now, but feel free to reopen if we decide to revert our previous decision to stop testing on Python 2.6 |
|
Hi @theengineear. I sympathise with not actively supporting py2.6. However a PR which introduces backward compatibility without breaking anything (and which passes all unit tests) seems to merit merging. Many hosts still only support py2.6 and it's a little silly to keep rebasing my patched fork version onto future changes here. Check out this hit counter link from one of my repos to see plotly.py2.6 in action: |
|
@casperdcl point definitely taken. Did you manage to find all the cases where we use http://stackoverflow.com/questions/19668395/str-format-for-python-2-6-gives-error-where-2-7-does-not I remember that being a pain. If you're sure those are all taken care of, I could be swayed. We should make sure to officially add it back as a tested version in our CI tests though. |
And I'll handle doing this portion since we do some funny things in our CI setup. |
|
I only fixed what was necessary to get this basic plot working. I could grep through the rest if you'd like. |
|
//cc @chriddyp , as much as I always want to move to Python 3, perhaps I've been a little over-zealous. I'm down to add back Python 2.6 if it's as painless as @casperdcl says ;) I can work on adding some commits to this PR that add back testing for Python 2.6. |
|
Sure, if it's not too much of a problem going forward then I'm OK with it. |
|
Closing as this PR is pretty stale and at this point we're not interested in supporting Python 2.6. Thanks! |
|
No worries. It's getting harder to support py2.6 every day. |
basic support for an old server running python2.6