-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fixes #414 #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #414 #416
Conversation
@cldougl Please review. I'll add some test cases as well.. |
Yep, it works for the example. Added tests as well.. :) |
@yankev : Getting 502, Bad gateway error on un-related tests (unrelated to this PR). :/ Update: It is passing now.. |
@tarzzz any update on this? seems like it'd be helpful :) |
@theengineear It is good to go in (I almost forgot I had made this PR) .. a quick 👀 from you or @cldougl before I merge it in .. 😺 |
if not (child is legend.get_children()[-1] | ||
and child.get_text() == 'None'): | ||
if (child is not legend.get_children()[-1] | ||
and child.get_text() != 'None'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you comment on this change? It seems unrelated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes #384 ..
I can made it as a different PR, or we can use this PR to kill two birds with a single stone.. 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, gotcha. 👍
if isinstance(obj, decimal.Decimal): | ||
return float(obj) | ||
else: | ||
raise NotEncodable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
@tarzzz, the default schema you have is likely quite out of date at this point. Would you mind:
I'm also happy to do this, but I am just a little unsure about the motivation for (2). |
@theengineear : Rebased with master, and updated the plot-schema.. |
Let's 💃 ! |
Fixes #414 and #384