Decode some html entities #835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
|
|
||
| it('wrap XSS attacks in href', function() { | ||
| var node = mockTextSVGElement( |
Contributor
Author
There was a problem hiding this comment.
reverting a commit from PR #804, as now <, > and " are now back in play.
Contributor
Author
src/constants/string_mappings.js
Outdated
| 'amp': '&', | ||
| 'lt': '<', | ||
| 'gt': '>', | ||
| 'quot': '\"', |
There was a problem hiding this comment.
" support makes me really uncomfortable since it's been part of so many of our XSS attacks (inserting a " sometimes allows an entity to be terminated early).
Is this definitely needed?
(The rest looks OK to me.)
Contributor
Author
There was a problem hiding this comment.
No, it isn't definitely needed. I thought it was common enough to be part of the list. I'll drop it.
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #804, we dropped html entity decoding for performance reasons, but apparently some folks have been using
&, , etc in their graphs. We need to bring back support for these ASAP.So, I propose supporting a few entities by translating them one-by-one to unicode.
This PR also DRYs up some code by making sure that
svg_text_utils.js(for svg text) andhtml2unicode(for WebGL text) use the same mappings.