Avoid npm start silently hanging forever on pollutants such as .DS_Store
#616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monfera
force-pushed
the
try-to-parse-json-only
branch
from
916ea9e to
a709cb4
Compare
| @@ -72,7 +72,7 @@ function readFiles(files) { | |||
| } | |||
|
|
|||
| function createMocksList(files) { | |||
| var mocksList = files.map(function(file) { | |||
| var mocksList = files.filter(function(file) {return file.extname === '.json';}).map(function(file) { | |||
There was a problem hiding this comment.
Nice find!
Can we make this filter clearer though? Something like:
// in case pollutants (e.g .DS_Store) got in the mock directory
var jsonFiles = files.filter( /* */ );
var mockList = jsonFiles.map(function(mock) { /* */ })
…ver on pollutants such as .DS_Store
monfera
force-pushed
the
try-to-parse-json-only
branch
from
a709cb4 to
34e07fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.