Skip to content

Relink matching axes categories during Plotly.relayout calls #4977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2020
Merged

Relink matching axes categories during Plotly.relayout calls #4977

merged 2 commits into from
Jul 2, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jul 2, 2020

Fixes #4971 (side effect of #4832)
the regression introduced in v1.54.2
i.e. by clearing categories only during Plotly.react calls.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable regression this used to work labels Jul 2, 2020
@archmoj archmoj requested a review from alexcjohnson July 2, 2020 17:20
alexcjohnson
alexcjohnson approved these changes Jul 2, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 💃

@archmoj archmoj merged commit 12303db into master Jul 2, 2020
@archmoj archmoj deleted the fix4971-matches-relink branch July 2, 2020 17:48
@alexcjohnson alexcjohnson mentioned this pull request Aug 6, 2020
Closed
@bishonen bishonen mentioned this pull request Dec 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken regression this used to work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hoverlabel not working properly with subplots when resizing window
2 participants
@archmoj @alexcjohnson