Skip to content

Conversation

etpinard
Copy link
Contributor

@mdtusz

Enforcing what we discussed in #256 (comment) .

In brief, npm run lint now enforces:

for(/* */) {

}

// and  similarly

if(/* */) { 

}

while(/* */) {

} 

function(/* */) { 

}

and spacing after colon in objects e.g. {a:10} is incorrect, {a: 10} is correct.

- so that if() and for() are the norm.
- so that: if() { / for() { and function() {
  not: if(){ / for(){ and function(){

  are the norm
@mdtusz
Copy link
Contributor

mdtusz commented Feb 29, 2016

I'll be honest in saying I didn't read through all 94 changed files, but the .eslintrc looks good.

Woo consistency!

💃

@etpinard
Copy link
Contributor Author

I'll be honest in saying I didn't read through all 94 changed files

can't blame you there.

etpinard added a commit that referenced this pull request Feb 29, 2016
@etpinard etpinard merged commit e39244d into master Feb 29, 2016
@etpinard etpinard deleted the linter-enforcers branch February 29, 2016 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants