Axis visible in 3D #1599
Merged
Axis visible in 3D #1599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- and replace it by Lib.extendFlat({}, /* */)
- no need to coerce attribute that don't have an effect
Merged
|
cc @rreusser |
src/plots/gl3d/layout/convert.js
Outdated
| this._defaultLineTickLength = arrayCopy1D(this.lineTickLength); | ||
| this._defaultTickPad = Lib.extendFlat([], this.tickPad); | ||
| this._defaultLabelPad = Lib.extendFlat([], this.labelPad); | ||
| this._defaultLineTickLength = Lib.extendFlat([], this.lineTickLength); |
There was a problem hiding this comment.
isn't this just .slice()?
There was a problem hiding this comment.
Oh right. Good 👁️ thanks!
|
Looks great to me - I can see this (in both 2D and 3D) being pretty nice for certain abstract plots! 💃 after my one comment. |
|
Definitely! Nice solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be merged in #1595
This PR implements
scene.(x|y|z)axis.visibleat the convert step.