more accurate 'boxing' of data_array properties. fixes #415 #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cpsievert merged 8 commits into master from fix/box

Jan 25, 2016

Collaborator

cpsievert commented Jan 21, 2016

No description provided.

cpsievert added 5 commits

January 20, 2016 21:24


          more accurate list of data_array properties. fixes #415

887372e


          bump version; update news

94aa22a


          if the trace type isn't found, provide some sensible defaults

873f476


          merge with master

aa19087


          (safely) mark individual nested properties

b6a541e

cpsievert changed the title ~~more accurate list of data_array properties. fixes #415~~ more accurate 'boxing' of data_array properties. fixes #415

cpsievert added 3 commits

January 25, 2016 16:16


          add a simple test

a1c70b4


          demonstrate with a test that we also fixed #424

2fb00ff


          only attach AsIs to length 1 vectors to make expect_equal happy

02350bb

Collaborator Author

cpsievert commented Jan 25, 2016

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/104764477

Detected 66 differences ->

http://cpsievert.github.io/plotly-test-table/3d4f44a/cookbook-axes-multiple-abline
http://cpsievert.github.io/plotly-test-table/3d4f44a/cookbook-axes-single-abline
http://cpsievert.github.io/plotly-test-table/3d4f44a/cookbook-lines-basic-horizontal-line
http://cpsievert.github.io/plotly-test-table/3d4f44a/cookbook-lines-dashed-red-line
http://cpsievert.github.io/plotly-test-table/3d4f44a/cookbook-lines-scatter-facet-hline
http://cpsievert.github.io/plotly-test-table/3d4f44a/cookbook-lines-scatter-facet-hline-vline
http://cpsievert.github.io/plotly-test-table/3d4f44a/cookbook-lines-scatter-hline
http://cpsievert.github.io/plotly-test-table/3d4f44a/cookbook-lines-scatter-hline-vline
http://cpsievert.github.io/plotly-test-table/3d4f44a/date-class-Date
http://cpsievert.github.io/plotly-test-table/3d4f44a/date-irregular-time-series
http://cpsievert.github.io/plotly-test-table/3d4f44a/date-strings
http://cpsievert.github.io/plotly-test-table/3d4f44a/errorbar
http://cpsievert.github.io/plotly-test-table/3d4f44a/errorbar-unique-groups
http://cpsievert.github.io/plotly-test-table/3d4f44a/histogram-vline
http://cpsievert.github.io/plotly-test-table/3d4f44a/hline
http://cpsievert.github.io/plotly-test-table/3d4f44a/hline-factor
http://cpsievert.github.io/plotly-test-table/3d4f44a/hline-multiple
http://cpsievert.github.io/plotly-test-table/3d4f44a/jitter-basic
http://cpsievert.github.io/plotly-test-table/3d4f44a/legend_name-lines_points_different_legend_name
http://cpsievert.github.io/plotly-test-table/3d4f44a/legend_name-lines_points_same_legend_name2
http://cpsievert.github.io/plotly-test-table/3d4f44a/linetype-colors
http://cpsievert.github.io/plotly-test-table/3d4f44a/linetype-types
http://cpsievert.github.io/plotly-test-table/3d4f44a/path-colored-groups-stay-together
http://cpsievert.github.io/plotly-test-table/3d4f44a/path-colors
http://cpsievert.github.io/plotly-test-table/3d4f44a/path-lines-diff-from-paths
http://cpsievert.github.io/plotly-test-table/3d4f44a/path-line-symbols
http://cpsievert.github.io/plotly-test-table/3d4f44a/polygon-aes-color
http://cpsievert.github.io/plotly-test-table/3d4f44a/polygon-aes-fill
http://cpsievert.github.io/plotly-test-table/3d4f44a/polygon-black
http://cpsievert.github.io/plotly-test-table/3d4f44a/polygon-color-aes-fill
http://cpsievert.github.io/plotly-test-table/3d4f44a/polygon-color-fill-aes-linetype
http://cpsievert.github.io/plotly-test-table/3d4f44a/polygon-color-fill-aes-size
http://cpsievert.github.io/plotly-test-table/3d4f44a/polygons-canada-borders
http://cpsievert.github.io/plotly-test-table/3d4f44a/polygon-star-fill-color
http://cpsievert.github.io/plotly-test-table/3d4f44a/polygon-star-group
http://cpsievert.github.io/plotly-test-table/3d4f44a/polygon-star-group-color
http://cpsievert.github.io/plotly-test-table/3d4f44a/rect-black
http://cpsievert.github.io/plotly-test-table/3d4f44a/rect-black4
http://cpsievert.github.io/plotly-test-table/3d4f44a/rect-color
http://cpsievert.github.io/plotly-test-table/3d4f44a/rect-fill
http://cpsievert.github.io/plotly-test-table/3d4f44a/rect-fill-color
http://cpsievert.github.io/plotly-test-table/3d4f44a/ribbon-alpha
http://cpsievert.github.io/plotly-test-table/3d4f44a/ribbon-colour
http://cpsievert.github.io/plotly-test-table/3d4f44a/ribbon-fill
http://cpsievert.github.io/plotly-test-table/3d4f44a/ribbon-group
http://cpsievert.github.io/plotly-test-table/3d4f44a/scatterplots-full-range
http://cpsievert.github.io/plotly-test-table/3d4f44a/scatterplots-geom_jitter
http://cpsievert.github.io/plotly-test-table/3d4f44a/scatterplots-jitter
http://cpsievert.github.io/plotly-test-table/3d4f44a/scatterplots-loess
http://cpsievert.github.io/plotly-test-table/3d4f44a/scatterplots-scale-color-hue
http://cpsievert.github.io/plotly-test-table/3d4f44a/scatterplots-smooth-lm
http://cpsievert.github.io/plotly-test-table/3d4f44a/scatterplots-smooth-lm-se-false
http://cpsievert.github.io/plotly-test-table/3d4f44a/segment
http://cpsievert.github.io/plotly-test-table/3d4f44a/segment-multiple-non-numeric
http://cpsievert.github.io/plotly-test-table/3d4f44a/size-global-scaling
http://cpsievert.github.io/plotly-test-table/3d4f44a/smooth-basic
http://cpsievert.github.io/plotly-test-table/3d4f44a/smooth-colour
http://cpsievert.github.io/plotly-test-table/3d4f44a/smooth-colour2
http://cpsievert.github.io/plotly-test-table/3d4f44a/smooth-facet
http://cpsievert.github.io/plotly-test-table/3d4f44a/smooth-fill2
http://cpsievert.github.io/plotly-test-table/3d4f44a/smooth-group
http://cpsievert.github.io/plotly-test-table/3d4f44a/smooth-se-false
http://cpsievert.github.io/plotly-test-table/3d4f44a/theme-marker-default
http://cpsievert.github.io/plotly-test-table/3d4f44a/vline
http://cpsievert.github.io/plotly-test-table/3d4f44a/vline-multiple
http://cpsievert.github.io/plotly-test-table/3d4f44a/ylim-one-trace

cpsievert added a commit that referenced this pull request


          Merge pull request #417 from ropensci/fix/box

more accurate 'boxing' of data_array properties. fixes #415

cpsievert merged commit 2650444 into master

cpsievert deleted the fix/box branch

January 28, 2016 02:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet