remove url_ok check since it won't work with proxy logins
#252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and anyways, let the user see the appropriate http status response by visiting the web page
|
Seems reasonable to me! +1 |
On TravisCI, commit a143d92 was successfully merged with 92c3ac4 (master) to create d389018. A visual testing table comparing 92c3ac4 with d389018 can be found here -> http://cpsievert.github.io/plotly-test-table/R/d389018/ Detected 0 differences |
chriddyp
added a commit
that referenced
this pull request
Aug 11, 2015
remove `url_ok` check since it won't work with proxy logins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and anyways, let the user see the appropriate http status response by visiting the web page and seeing the server's response
fixes #251
cc @cpsievert @mkcor