Merge pull request #252 from ropensci/remove_httr_url_ok

chriddyp · chriddyp · commit a97299c1f864 · 2015-08-11T13:35:50.000-04:00
remove `url_ok` check since it won't work with proxy logins
diff --git a/R/print.R b/R/print.R
@@ -10,7 +10,7 @@
 print.plotly <- function(x, ...) {
   l <- plotly_POST(x)
   if (!is.null(l$url)) {
-    if (httr::url_ok(l$url) && interactive()) browseURL(l$url)
+    if (interactive()) browseURL(l$url)
   }
   # get_figure() instead?
   invisible(l)

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`print.plotly <- function(x, ...) {`
`11`	`11`	`l <- plotly_POST(x)`
`12`	`12`	`if (!is.null(l$url)) {`
`13`		`- if (httr::url_ok(l$url) && interactive()) browseURL(l$url)`
	`13`	`+ if (interactive()) browseURL(l$url)`
`14`	`14`	`}`
`15`	`15`	`# get_figure() instead?`
`16`	`16`	`invisible(l)`