Skip to content

Conversation

FrankBornais
Copy link

@FrankBornais FrankBornais commented Mar 13, 2021

@cpsievert
Copy link
Collaborator

Thank you!

If you don't mind, a NEWS item would also be helpful.

@cpsievert
Copy link
Collaborator

Hmm, do you know what's going on with these differences?

Screen Shot 2021-03-17 at 6 43 07 PM

@cpsievert
Copy link
Collaborator

Oh I think they might be a result of #1927?

@FrankBornais
Copy link
Author

FrankBornais commented Mar 17, 2021

Oh I think they might be a result of #1927?

Yes that's it. Since it kept only 6 symbols to remove an unnecessary warning in the tests... If you want me to undo that just let me know.

@cpsievert
Copy link
Collaborator

I think most of the changes are fine except for tests/figs/subplot/subplot-bump-axis-annotation-traces-shared.svg and tests/figs/subplot/subplot-bump-axis-annotation-traces.svg. It looks like you added a type = "scatter" when it really wasn't needed (doing so adds an extra empty trace) -- would you mind reverting that change?

BTW, thank you for updating these visual baselines!!

@cpsievert cpsievert merged commit 8341a47 into plotly:master Mar 18, 2021
@cpsievert
Copy link
Collaborator

Thanks!

@FrankBornais FrankBornais deleted the fix-traceNames branch March 18, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants