Skip to content

ggplotly(): fix Xaxis anchor if the last row incomplete #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 15, 2019
Merged

ggplotly(): fix Xaxis anchor if the last row incomplete #1501

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0b74e8d
ggplotly: fix Xaxis anchor if the last row incomplete
alyst Mar 18, 2019
414fbe1
stylistic changes
cpsievert Apr 3, 2019
8a8878d
validate new visual baselines
cpsievert Apr 3, 2019
8a5b8c3
merge conflicts
cpsievert Apr 4, 2019
51c7437
Merge branch 'master' into fix_wrap_axes
cpsievert Apr 8, 2019
3c85052
Doesn't seem like we need to handle yaxis being a factor
cpsievert Apr 8, 2019
ddb8b30
merge with master
cpsievert Jul 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 25 additions & 17 deletions R/ggplotly.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,27 +459,35 @@ gg2list <- function(p, width = NULL, height = NULL,

# panel -> plotly.js axis/anchor info
# (assume a grid layout by default)
layout$layout$xaxis <- layout$layout$COL
layout$layout$yaxis <- layout$layout$ROW
layout$layout$xanchor <- nRows
layout$layout$yanchor <- 1
layout$layout <- dplyr::mutate(layout$layout,
xaxis = COL,
yaxis = ROW,
xanchor = nRows,
yanchor = 1L)
if (inherits(plot$facet, "FacetWrap")) {
if (plot$facet$params$free$x) {
layout$layout$xaxis <- layout$layout$PANEL
layout$layout$xanchor <- layout$layout$ROW
}
if (plot$facet$params$free$y) {
layout$layout$yaxis <- layout$layout$PANEL
layout$layout$yanchor <- layout$layout$COL
layout$layout$xanchor <- nPanels
}
if (plot$facet$params$free$x && plot$facet$params$free$y) {
layout$layout$xaxis <- layout$layout$PANEL
layout$layout$yaxis <- layout$layout$PANEL
layout$layout$xanchor <- layout$layout$PANEL
layout$layout$yanchor <- layout$layout$PANEL
layout$layout <- dplyr::mutate(layout$layout,
xaxis = PANEL,
yaxis = PANEL,
xanchor = PANEL,
yanchor = PANEL)
} else if (plot$facet$params$free$x) {
layout$layout <- dplyr::mutate(layout$layout,
xaxis = PANEL,
xanchor = ROW)
} else if (plot$facet$params$free$y) {
layout$layout <- dplyr::mutate(layout$layout,
yaxis = PANEL,
yanchor = COL)
}
# anchor X axis to the lowest plot in its column
layout$layout <- dplyr::group_by(layout$layout, xaxis) %>%
dplyr::mutate(xanchor = max(as.integer(yaxis))) %>%
dplyr::ungroup() %>%
dplyr::mutate(xanchor = if (is.factor(yaxis)) levels(yaxis)[xanchor] else xanchor)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't immediately follow why dplyr::mutate(xanchor = if (is.factor(yaxis)) levels(yaxis)[xanchor] else xanchor) is necessary, do you have an example in mind where this becomes relevant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it looks a bit ugly. I had trouble with some of the plots (maybe even the ones in the tests) when either a PANEL or COL is a factor.
There was some error happening afterwards, but unfortunately I forgot the details. So I had to convert xanchor back to a factor.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alyst tests are passing without it -- I would be very grateful if you can report a case where 3c85052 doesn't do what you'd expect!

layout$layout <- as.data.frame(layout$layout)

# format the axis/anchor to a format plotly.js respects
layout$layout$xaxis <- paste0("xaxis", sub("^1$", "", layout$layout$xaxis))
layout$layout$yaxis <- paste0("yaxis", sub("^1$", "", layout$layout$yaxis))
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-ggplot-facets.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,5 +140,5 @@ test_that("when y scales are free, x-axes are still anchored on exterior", {
info <- expect_doppelganger_built(p, "facet_wrap-free_y-2")
xaxes <- info$layout[grep("^xaxis", names(info$layout))]
yaxes <- info$layout[grep("^yaxis", names(info$layout))]
expect_equivalent(unique(sapply(xaxes, "[[", "anchor")), "y5")
expect_equivalent(unique(sapply(xaxes, "[[", "anchor")), c("y5", "y4"))
})