Skip to content

Relay customdata #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 21, 2019
Merged

Relay customdata #1423

merged 4 commits into from
Jan 21, 2019

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Dec 5, 2018 •
edited
Loading

Closes #1162

Testing Notes

Install remotes::install_github('ropensci/plotly#1423'), then run the following:

shiny::runGitHub("plotly", "ropensci", ref = "customdata", subdir = "inst/examples/shiny/event_data")

Confirm that when you hover/click/brush points, that the event data contains a customdata column

@cpsievert cpsievert requested a review from schloerke December 5, 2018 02:53
@schloerke schloerke requested a review from jcheng5 December 5, 2018 16:23
@cpsievert cpsievert mentioned this pull request Dec 7, 2018
Merged
1 task
@cpsievert cpsievert merged commit c54ac8f into master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@schloerke schloerke schloerke approved these changes

@jcheng5 jcheng5 jcheng5 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpsievert @schloerke @jcheng5