leverage custom writer in vdiffr #1369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
vdiffr-writer
branch
from
953cae9 to
6b8f4ed
Compare
cpsievert
force-pushed
the
vdiffr-writer
branch
2 times, most recently
from
f5f1822 to
37da1b9
Compare
Note the changes went uncaught because travis stopped building at some point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes rely on https://github.com/lionel-/vdiffr/pull/48. That PR should be merged first, but strictly speaking, it doesn't have to since the dependency managed via https://hub.docker.com/r/cpsievert/plotly-orca/)