Skip to content

plotly.js v1.41.3 #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 8, 2018
Merged

plotly.js v1.41.3 #1338

merged 9 commits into from
Oct 8, 2018

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Sep 18, 2018

The new layout.clickmode = "select" plotly.js attribute conflicts with the crosstalk framework (when the highlighting event is plotly_click, which is the default). For example:

d <- highlight_key(mtcars)
qplot(data = d, x = mpg, y = wt) %>%
  subplot(qplot(data = d, x = mpg, y = vs)) %>% 
  layout(clickmode = "select")

I don't think it's worth the time to try to get the two working well together because layout.clickmode = "select" doesn't provide anything that the current crosstalk framework already provides, so I decided to just throw a warning if I detect layout.clickmode = "select" when in a crosstalk key is present and the relevant event is plotly_click.

Testing notes

This PR upgrades the underlying JS library from v1.40.1 to 1.41.3. It should be sufficient to just make sure this example renders on all platforms #1359 (comment)

@cpsievert cpsievert changed the title plotly.js v1.41.0 plotly.js v1.41.2 Sep 20, 2018
@cpsievert cpsievert changed the title plotly.js v1.41.2 plotly.js v1.41.3 Oct 4, 2018
@cpsievert cpsievert requested a review from jcheng5 October 4, 2018 15:12
@cpsievert cpsievert merged commit 2bf7aa8 into master Oct 8, 2018
cpsievert added a commit that referenced this pull request Oct 16, 2018
Note the changes went uncaught because travis stopped building at some point
cpsievert added a commit that referenced this pull request Oct 16, 2018
Note the changes went uncaught because travis stopped building at some point
cpsievert added a commit that referenced this pull request Oct 16, 2018
Note the changes went uncaught because travis stopped building at some point
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants