Skip to content

Remove iris from examples #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cpsievert opened this issue Jun 11, 2020 · 4 comments · Fixed by #1830
Closed

Remove iris from examples #1790

cpsievert opened this issue Jun 11, 2020 · 4 comments · Fixed by #1830

Comments

@cpsievert
Copy link
Collaborator

Instead use https://github.com/allisonhorst/palmerpenguins when it's on CRAN

@julistanley
Copy link
Contributor

julistanley commented Jul 31, 2020

This was pushed to CRAN a few days ago now (https://cran.r-project.org/web/packages/palmerpenguins/index.html).

Do you also want to remove iris from the tests? I only see 4 instances of iris in the examples (so that was a quick switch), but quite a few in test-plotly, test-ggplot-legend, test-ggplot-theme, test-ggplot-symbol, test-ggplot-labels, test-api, test-plotly-color, test-plotly-subplot, and test-ggplot-size.

Edit: you also use iris a good bit in the plotly-r.com book. Do you want to replace those, too?

@cpsievert
Copy link
Collaborator Author

I'd say the book would be a better change than the tests, but both would be welcome, thanks!

@superjai
Copy link

Hello! I am an ecologist and an admirer from afar of Ropensci for some time. I thought that I might jump in to actually help with things. Stefanie Butland suggested that I should take a look at open issues, as a way to get started with helping. This particular issue seems like a very easy place to get started. I am happy to work on this issue, but before I get started, I wanted to double check that this was still actually an open issue (the message at the top of the screen indicates that Commit #1830 might have fixed this issue). On the other hand, I still see references to iris in the package. Thanks! Jai

@cpsievert
Copy link
Collaborator Author

Hi @jai, yes, #1830 closes this issue (I just merged it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants