-
Notifications
You must be signed in to change notification settings - Fork 7
Update pip from 19.3.1 to 20.2.4 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gzork please review. |
@BRONSOLO just wanted to check in with you re the test steps and confirm the container to test the |
Hey @vanastassiou the testing steps look good but additional changes are needed for this PR in the end as we're vendoring the pip version being used:
Given the change to dds-vendor in 1), the image will need to be updated within the Replicated yaml for testing as well. |
cf20f51
to
893eff3
Compare
@tarzzz please review. |
Hey folks - I was reading through the heroku-buildpack-python CHANGELOG tonight and came across this: heroku/heroku-buildpack-python#1007. If we're updgrading the heroku buildpack too, then maybe the way we upgrade |
@chriddyp Upstream does opt to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
@vanastassiou Can you please add a note in https://github.com/plotly/streambed/issues/15131 about Chris' comment so that it's not lost when we merge this PR.? |
https://github.com/plotly/streambed/issues/14939
The updated
get-pip.py
was generated as follows:Tested as follows:
dds-vendor
Dockerfile
to install newpip
versiondds-vendor
image.buildpacks
file containinghttps://github.com/plotly/heroku-buildpack-python.git#update-pip
exec
into Dash app container and/app/.heroku/python/bin/pip --version