Skip to content

explicitly set width of iframe for advanced violin example to fix layout #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2019
Merged

explicitly set width of iframe for advanced violin example to fix layout #1223

merged 1 commit into from
Jan 2, 2019

Conversation

michaelbabyn
Copy link
Contributor

fix #1209 by explicitly setting the width of the codepen's iframe to 700 pixels

@michaelbabyn michaelbabyn added the ReviewReady This PR is ready for review label Dec 31, 2018
@cldougl cldougl removed the ReviewReady This PR is ready for review label Dec 31, 2018
@cldougl cldougl self-requested a review December 31, 2018 20:52
cldougl
cldougl approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@cldougl cldougl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@michaelbabyn michaelbabyn merged commit d1f13b5 into source-design-merge Jan 2, 2019
@michaelbabyn michaelbabyn deleted the violin-advanced-layout-fix branch January 2, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cldougl cldougl cldougl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Codepen formatting issue on JS violin plots page
2 participants
@michaelbabyn @cldougl