Skip to content

Fix suppress_callback_exceptions config #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Fix suppress_callback_exceptions config #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d659b1c
Add config key
HammadTheOne Sep 22, 2021
d6478ab
Fixing CI
HammadTheOne Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,10 @@ jobs:
- run:
name: ⚙️ Integration tests
command: |
curl --proto '=https' --tlsv1.2 -sSf -o rust-init.sh https://sh.rustup.rs
chmod ugo+x rust-init.sh
./rust-init.sh -y
python -m venv venv
. venv/bin/activate
pip install --upgrade pip
git clone --depth 1 https://github.com/plotly/dash.git dash-main
export PATH=$PATH:/home/circleci/.local/bin/:/home/circleci/.cargo/bin
export RUSTC_BOOTSTRAP=1
cd dash-main && pip install -e .[dev,testing] --progress-bar off && cd ..
cd dash-main/\@plotly/dash-generator-test-component-nested && npm ci && npm run build && sudo R CMD INSTALL . && cd ../../..
cd dash-main/\@plotly/dash-generator-test-component-standard && npm ci && npm run build && sudo R CMD INSTALL . && cd ../../..
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).

### Fixed
- Minor fix for favicon issue continued from [#240](https://github.com/plotly/dashr/pull/240) (for more details, see [#243](https://github.com/plotly/dashR/pull/243#issuecomment-842813526)).
- Minor fix to enable `suppress_callback_exceptions` configuration option when creating a Dash app. [#268](https://github.com/plotly/dashr/pull/268)


## [0.9.1] - 2020-11-16
### Fixed
Expand Down
1 change: 1 addition & 0 deletions R/dash.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ Dash <- R6::R6Class(
self$config$external_stylesheets <- external_stylesheets
self$config$show_undo_redo <- show_undo_redo
self$config$update_title <- update_title
self$config$suppress_callback_exceptions <- suppress_callback_exceptions

# ensure attributes are valid, if using a list within a list, elements are all named
assertValidExternals(scripts = external_scripts, stylesheets = external_stylesheets)
Expand Down