remove .vscode directory

[Batalex]

Contributor Checklist

• I have broken down my PR scope into the following TODO tasks
  • fix Remove editor configuration from repo #834. Remove .vscode/ dir from git stage. It should be properly ignored for everyone using VS Code now.

We could also use this PR to discuss the addition of a .editorconfig file. The homepage shows a nice example of an editor configuration file for both Python & JS.

[byronz]

I'm fine to remove the vscode settings, and like the idea of a generic editorconfig across different IDEs. a customized version would look like this

# EditorConfig is awesome: https://EditorConfig.org

# Unix-style newlines with a newline ending every file
[*]
end_of_line = lf

# Matches multiple files with brace expansion notation
# Set default charset
[*.{js,py}]
charset = utf-8

# 4 space indentation
[*.py]
indent_style = space
indent_size = 4
insert_final_newline = true

# Tab indentation (no size specified)
[Makefile]
indent_style = tab

# Indentation override for all JS under lib directory
[lib/**.js]
indent_style = space
indent_size = 2

# Matches the exact files either package.json or .travis.yml
[{package.json,.circleci/config.yml}]
indent_style = space
indent_size = 2

@alexcjohnson @Marc-Andre-Rivet

[alexcjohnson]

Sounds good to me, and this config looks like a good starting point except that our js source uses 4-space indentation just like the py source.

[Batalex]

A shorter version would be

# EditorConfig is awesome: https://EditorConfig.org

# Unix-style newlines with a newline ending every file
[*]
end_of_line = lf
insert_final_newline = true

# Matches multiple files with brace expansion notation
# Set default charset
[*.{js,py}]
charset = utf-8
indent_style = space
indent_size = 4

# Matches the exact files either package.json or .travis.yml
[{package.json,.circleci/config.yml}]
indent_style = space
indent_size = 2

Is this ok?
The editors support is listed here. Pycharm users would instantly benefit from it whereas Sublime/Atom/VSCode would need to install a dedicated plugin.

[byronz]

@alexcjohnson is this valid for js file ?
insert_final_newline = true

[alexcjohnson]

Currently I have my editor set to include a trailing newline on all files, regardless of type. So yes, definitely valid for js

[byronz]

💃 thanks for @Batalex