This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Loading states data attribute #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Released as rc version 0.14.0rc20 (rc1 to rc6 where taken - leaving a bit of room there) |
Contributor
Marc-Andre-Rivet
left a comment
Marc-Andre-Rivet
left a comment
There was a problem hiding this comment.
A few comment, nothing major.
CHANGELOG.md
Outdated
| All notable changes to this project will be documented in this file. | ||
| This project adheres to [Semantic Versioning](http://semver.org/). | ||
|
|
||
| ## [0.14.0] - Unreleased |
Contributor
There was a problem hiding this comment.
For the final merge this will need to simply be unreleased and the version change in package.json to be reverted.
| </xmp> | ||
| ); | ||
| }; | ||
|
|
Contributor
There was a problem hiding this comment.
It would make sense to also omit loading_state from the props being passed down to the child
Contributor
Author
There was a problem hiding this comment.
Since the Loading component checks the loading_state prop, if we were to omit it, the Loading component would not work anymore, so I don't think we should omit it.
…prop coming from dash-renderer
Contributor
Author
|
released as rc version |
Marc-Andre-Rivet
approved these changes
Feb 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
loading_statesprop from plotly/dash-renderer#93 to all components, as well as adata-dash-is-loadingattribute to all components that holdsloading_states.is_loading.