Skip to content

Conversation

Karan-S-Mittal
Copy link
Contributor

  1. issue Graduated bar margin bug #39: removed style from internal components of GraduatedBar and applies style only on root element
  2. issue Tank Component's Current Value's color becomes same/similar and is invisible if tank's value is over half #155: added a new prop currentValueStyle in daq.Tank component which takes the same input dict as style attribute.
  3. issue Client side Validation bug with BooleanSwitch  #118: replaced the 'on' value passed in the persisted props with 'value'
  4. issue Slider should auto size to fit Div #76: added a new prop/attribute fullSize in daq.Slider component which takes in boolean value True/False. for vertical=True you will need to provide a custom-defined height in units (px, em, etc...) otherwise fullSize=True will not work.

M-Ali-D and others added 7 commits October 6, 2021 22:46
issue 39: removed style from internal components of GraduatedBar and applies style only on root element
issue 155: added a new prop currentValueStyle in daq.Tank component which takes the same input dict as style attribute.
issue 118: replaced the 'on' value passed in the persisted props with 'value'
issue plotly#76: added a new prop/attribute fullSize in daq.Slider component which takes in boolean value True/False.
for vertical=True you will need to provide a custom defined height in units (px, em, etc...) otherwise fullSize=True will not work.
@jackparmer
Copy link
Contributor

@vinicvaz or @luiztauffer can you please review?

@luiztauffer
Copy link
Contributor

I'll look at that tomorrow!

@luiztauffer
Copy link
Contributor

luiztauffer commented Oct 12, 2021

@Karan-S-Mittal

image

@Karan-S-Mittal
Copy link
Contributor Author

for issue #14 you can check the preview here

Screen.Recording.2021-10-21.at.11.37.08.PM.mov

.

@Karan-S-Mittal
Copy link
Contributor Author

Hey @luiztauffer,
can you please review the changes?
Regards,
Karan

@jackparmer jackparmer merged commit 2799847 into plotly:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants