Add frames to Graph

[nicolaskruchten]

frames are part of the Plotly.js figure spec, so dcc.Graph() should accept them.

[nicolaskruchten]

I'm not sure what Percy is up to here... @alexcjohnson what's your recommendation? rerun? approve?

[alexcjohnson]

We've seen that percy diff before, have to track it down at some point but it's OK for now.

Does this PR work though? Doesn't look like frames are propagated to Plotly.react

dash-core-components/src/components/Graph.react.js

Line 101 in bab0d52

return Plotly.react(id, figure.data, clone(figure.layout), config).then(

in fact we have to use the other signature Plotly.react(gd, {data, layout, frames, config}) in order to use frames, right?

[nicolaskruchten]

Good point, I hadn't actually dug in that far :)

[nicolaskruchten]

Do you think I should clone frames or not?

[alexcjohnson]

Shouldn’t need cloning, no.

[nicolaskruchten]

OK so this one actually works now @alexcjohnson :)

[nicolaskruchten]

I've approved that same Percy diff, so this one should be good to review.

[nicolaskruchten]

Do you want a changelog entry here also?

[nicolaskruchten]

OK I added one.

[alexcjohnson]

Looks good! 💃
I'd prefer including frames in a test, but if you want to get this in quick I'm OK without it - just know I'm going to forward any frames bugs to you 😏

[nicolaskruchten]

🤝 deal.