Async dash bio #430
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,9 @@ | ||
| { | ||
| "presets": [ | ||
| "@babel/env", | ||
| "@babel/react" | ||
| ], | ||
| "plugins": [ | ||
| "@babel/plugin-syntax-dynamic-import" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,17 +32,50 @@ | |
|
|
||
| _this_module = _sys.modules[__name__] | ||
|
|
||
| async_resources = [ | ||
| 'alignment', | ||
| 'circos', | ||
| 'ideogram', | ||
| 'moleculeviewer2', | ||
| 'moleculeviewer3', | ||
| 'needle', | ||
| 'onco', | ||
| 'sequence', | ||
| 'speck' | ||
| ] | ||
|
|
||
| _js_dist = [] | ||
|
|
||
| _js_dist.extend([{ | ||
| 'relative_package_path': 'async~{}.js'.format(async_resource), | ||
| 'external_url': ( | ||
| 'https://unpkg.com/dash-bio@{}' | ||
| '/dash_bio/async~{}.js' | ||
| ).format(__version__, async_resource), | ||
| 'namespace': 'dash_bio', | ||
| 'async': True | ||
| } for async_resource in async_resources]) | ||
|
|
||
| _js_dist.extend([{ | ||
| 'relative_package_path': 'async~{}.js.map'.format(async_resource), | ||
| 'external_url': ( | ||
| 'https://unpkg.com/dash-bio@{}' | ||
| '/dash_bio/async~{}.js.map' | ||
| ).format(__version__, async_resource), | ||
| 'namespace': 'dash_bio', | ||
| 'dynamic': True | ||
| } for async_resource in async_resources]) | ||
|
|
||
| _js_dist.extend([ | ||
| { | ||
| 'relative_package_path': 'bundle.js', | ||
| 'external_url': ( | ||
| 'https://unpkg.com/dash-bio{}' | ||
| '/' + package_name + '/bundle.js' | ||
| ).format(__version__), | ||
|
There was a problem hiding this comment. Hey not new in this PR, but There was a problem hiding this comment. 🔎 Interesting, due to how There was a problem hiding this comment. Someone using the remotely hosted code for an old version will have a nasty surprise after this update.. There was a problem hiding this comment. @alexcjohnson Good catch! Surprised we haven't run into it before. |
||
| 'namespace': package_name | ||
| } | ||
| ]) | ||
|
|
||
| _css_dist = [] | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR, but at some point - like perhaps, whenever we get around to fully generating
__init__.py- this all seems ripe for abstracting into the dash core, likeMay still need some tweaking to handle edge cases like
async: 'eager'|'lazy', but we should at least be able to auto-detect sourcemaps (which may not exist in release versions plotly/dash#910) and set them alldynamic: Trueregardless of the resource setting.