Fix CI #617
Fix CI #617
Conversation
| else | ||
| echo "This is not a pull request event" | ||
| echo "Running all tests" | ||
| exit 1 |
There was a problem hiding this comment.
I guess exit 1 will make the action failure?
Should we do exit 0?
There was a problem hiding this comment.
To run all tests, we want check_doc to fail. The test main purpose to determine whether anything other than doc has been modified. The test will fail if anything other than doc was modified and will run all tests.
There was a problem hiding this comment.
OK just saw continue-on-error: true
So I guess that still marks the failing step as "succeeded"?
There was a problem hiding this comment.
continue-on-error: true make sure that the jobs below will run irrespective of the failure or success of a step.
I am using the statement the outcome of the step to determine whether the next test will run or not.
if: needs.check_doc.outputs.check_doc_modified == 'failure'
There was a problem hiding this comment.
I see, logically it looks good to me.
Need to merge to master to verify
2 participants
Describe your changes
When the PR is merged into master, CI is not running.
Explanation
Issue number
Closes #X
Checklist before requesting a review
pkgmt format📚 Documentation preview 📚: https://jupysql--617.org.readthedocs.build/en/617/