This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Support chrome devtool connection #724
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Select connect function based on endpointURL being set
|
@BitFis could you please add |
Pull Request Test Coverage Report for Build 900367984
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I Run into the issue, that the chrome devtool connection (
connectOverCDP) as defined in https://playwright.dev/docs/api/class-browsertype/#browsertypeconnectovercdpparams is not supported. This addition would allow such a support by checking for theendpointURLargument in options and selecting connect function accordingly.I hope this helps improve the extension.
Great work ❤️