Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

chambo-e
Copy link
Contributor

Hello, just crossed a tiny bug when trying to extend the context defined in the config with a jestPlaywright.resetContext

My configuration storageState was overwriten by the newContext while it should have been merged :)

@mmarkelov
Copy link
Member

@chambo-e lgtm for me.
@mxschmitt by the way i think about replacing custom deepMerge function with deepmerge. What do you think?

@mxschmitt
Copy link
Collaborator

@chambo-e lgtm for me.
@mxschmitt by the way i think about replacing custom deepMerge function with deepmerge. What do you think?

makes sense!

@chambo-e
Copy link
Contributor Author

@chambo-e lgtm for me.
@mxschmitt by the way i think about replacing custom deepMerge function with deepmerge. What do you think?

makes sense!

I can include it in this PR if you want

@mmarkelov
Copy link
Member

@chambo-e I think that replacing custom deepMerge should be done in separate PR

@chambo-e
Copy link
Contributor Author

@mmarkelov alright, I'll open another PR once this one is merged :)

I'v corrected the tests by spreading DEFAULT_CONFIG instead of deepMerge-ing it with other configurations. As DEFAULT_CONFIG only has top level keys I don't think there will be any issues.
Let me know if you want to try another approach

@coveralls
Copy link

coveralls commented Apr 29, 2021

Pull Request Test Coverage Report for Build 793505385

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.01%) to 94.798%

Files with Coverage Reduction New Missed Lines %
src/utils.ts 1 94.41%
Totals Coverage Status
Change from base Build 784546029: -1.01%
Covered Lines: 106
Relevant Lines: 109

💛 - Coveralls

@mmarkelov
Copy link
Member

@chambo-e sorry for late response. Seems ok for me. @mxschmitt i suppose we can merge it. What do you think?

@mmarkelov mmarkelov merged commit 85dc15e into playwright-community:master May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants