Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions src/utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -205,28 +205,38 @@ describe('getBrowserType', () => {
})

describe('getBrowserOptions', () => {
it('should return undefined for empty options', async () => {
it('should return empty object for empty options', () => {
const options = getBrowserOptions(CHROMIUM)
expect(options).toBe(undefined)
expect(options).toStrictEqual({})
})

it('should return root options', async () => {
it('should return root options', () => {
const launchOptions = { headless: false }
const options = getBrowserOptions(CHROMIUM, launchOptions)
expect(options).toBe(launchOptions)
expect(options).toStrictEqual(launchOptions)
})

it('should return options for defined browser', async () => {
it('should return options for defined browser', () => {
const launchOptions = { headless: false, chromium: { headless: true } }
const options = getBrowserOptions(CHROMIUM, launchOptions)
expect(options).toStrictEqual({ headless: true })
})

it('should return root options for other browser', async () => {
it('should return root options for other browser', () => {
const launchOptions = { headless: false, chromium: { headless: true } }
const options = getBrowserOptions(FIREFOX, launchOptions)
expect(options).toStrictEqual({ headless: false })
})

it('should not mutate original options', () => {
const launchOptions = { headless: false, chromium: { headless: true } }
const options = getBrowserOptions(FIREFOX, launchOptions)
expect(options).toStrictEqual({ headless: false })
expect(launchOptions).toStrictEqual({
headless: false,
chromium: { headless: true },
})
})
})

describe('checkBrowserEnv', () => {
Expand Down
19 changes: 8 additions & 11 deletions src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,17 +164,14 @@ export function getBrowserOptions<T>(
browserName: BrowserType,
options?: Options<T>,
): T {
let result: Options<T> | undefined = options
if (result) {
if (result[browserName]) {
result = deepMerge(result, result[browserName]!)
}
BROWSERS.forEach((browser) => {
delete result![browser as BrowserType]
})
return result
}
return result as T
let result: Options<T> = options ? { ...options } : ({} as T)
if (result[browserName]) {
result = deepMerge(result, result[browserName]!)
}
BROWSERS.forEach((browser) => {
delete result![browser as BrowserType]
})
return result
}

export const getSkipFlag = (
Expand Down