Deprecate setting browser and device with env

[mmarkelov]

close #531

[mxschmitt]

Not sure if this is a good idea tho. Since it's common to "shard" the tests by browser type with e.g. GitHub Actions and pass then the browser type or device type as an environment variable to the actual process. Probably it can be still be used when using the process.env variables in the jest-playwright.config.js or what do you think?

[mmarkelov]

@mxschmitt I'm not sure that I understood you. Do you think that we should keep this logic?
I just can't check this issue #531, we can keep this logic but rename this to JEST_PLAYWRIGHT_BROWSER for example.
I just thought that this logic was useful.

[mxschmitt]

@mxschmitt I'm not sure that I understood you. Do you think that we should keep this logic?
I just can't check this issue #531, we can keep this logic but rename this to JEST_PLAYWRIGHT_BROWSER for example.
I just thought that this logic was useful.

I think it's fine to remove it but we should add to the readme how the users can control the browser with their environment variable. Something like that should work then in my mind:

module.exports = {
  browsers: [process.env.BROWSER],
}

[coveralls]

Pull Request Test Coverage Report for Build 501819593

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.2%) to 95.906%

---

Totals
Change from base Build 493937069:	-0.2%
Covered Lines:	105
Relevant Lines:	107

---

💛 - Coveralls