This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Some improvements #479
Merged
Some improvements #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 401436923
💛 - Coveralls |
kenny-f
reviewed
Dec 7, 2020
Comment on lines
+135
to
+136
| jestPlaywrightDebug: JestPlaywrightTestDebug | ||
| jestPlaywrightConfig: JestPlaywrightTestConfig |
There was a problem hiding this comment.
@mmarkelov is this correct?
in https://github.com/playwright-community/jest-playwright/blob/master/src/extends.ts#L104
I don't see describe being extended with jestPlaywrightDebug or jestPlaywrightConfig. Only jestPlaywrightSkip.
Or am I missing something?
There was a problem hiding this comment.
@kenny-f my bad. I'll think about if we need these kind of helpers for describe or we just want to skip only
There was a problem hiding this comment.
@mmarkelov I think it's useful to have for describe as well as it allows people to group tests differently and not be restricted by what is extended and what isn't.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #477